Re: [Qemu-devel] [PATCH] linux-user: Use the 5KEf processor for 64-bit emulation

[Leon Alrae]

On 20/11/2014 16:00, Maciej W. Rozycki wrote:
> Replace the 20Kc original MIPS64 ISA processor used for 64-bit user
> emulation with the 5KEf processor that implements the MIPS64r2 ISA,
> complementing the choice of the 24Kf processor for 32-bit emulation.
> 
> Signed-off-by: Maciej W. Rozycki <address@hidden>
> ---
> Hi,
> 
>  For user emulation mode I think we want to default to the highest ISA 
> level supported, for maximum user flexibility.  Currently the MIPS64r2 
> ISA is the highest 64-bit ISA we have a real processor support for so 
> use it and the 5KEf which is the processor we have that implements it.  
> Later, as newer processors are added, we can bump it further up.
> 
>  I think we should consider picking something for microMIPS support too 
> sometime, perhaps based on ELF file flags, however the thing is with 
> that we have no FPU processor to choose.  So let's skip it for now.
> 
>  I have tested it lightly by running the GCC test suite for the 
> mips-linux-gnu target and the n64 ABI (`-EB -mabi=64' multilib), using 
> MIPS64r2 code.
> 
>  Please apply.
> 
>   Maciej
> 
> qemu-mips-user-5kef.diff
> Index: qemu-git-trunk/linux-user/main.c
> ===================================================================
> --- qemu-git-trunk.orig/linux-user/main.c     2014-11-20 10:47:31.000000000 
> +0000
> +++ qemu-git-trunk/linux-user/main.c  2014-11-20 10:50:57.098940605 +0000
> @@ -3929,7 +3929,7 @@ int main(int argc, char **argv, char **e
>  #endif
>  #elif defined(TARGET_MIPS)
>  #if defined(TARGET_ABI_MIPSN32) || defined(TARGET_ABI_MIPSN64)
> -        cpu_model = "20Kc";
> +        cpu_model = "5KEf";
>  #else
>          cpu_model = "24Kf";
>  #endif
> 

Reviewed-by: Leon Alrae <address@hidden>