Re: [Qemu-devel] [RFC PATCH v5 07/31] icount: implement icount requesting

[Paolo Bonzini]

On 05/12/2014 06:34, Pavel Dovgaluk wrote:
>> From: Paolo Bonzini [mailto:address@hidden
>> On 04/12/2014 12:02, Pavel Dovgaluk wrote:
>>>>> Why do you need to do this if !cpu_can_do_io(cpu)?
>>> We save number of executed instruction when saving interrupt or exception 
>>> event.
>>> It leads to the call of cpu_get_instructions_counter() from cpu_exec 
>>> function
>>> (through several replay functions). It is correct (because no block is 
>>> executing
>>> at that moment) but is different to prior usage of icount requests.
>>
>> Why is !cpu_can_do_io(cpu) if no block is executing?
> 
> Because it returns cpu->can_do_io which is equal to zero at that moment.

And why is can_do_io zero? :)  Is the fix to move the place where
can_do_io becomes nonzero?

Paolo