qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] spice: fix memory leak


From: Eric Blake
Subject: Re: [Qemu-devel] [PATCH] spice: fix memory leak
Date: Thu, 04 Dec 2014 21:59:16 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0

On 12/04/2014 08:31 PM, address@hidden wrote:
> From: Gonglei <address@hidden>
> 
> If errors happen for middle items of channel_list,
> qmp_query_spice_channels() return NULL, and varriable

s/return/returns/
s/varriable/the variable/

> cur_item going out of scope leaks the storage it points to.
> Let's check for errors in advance avoid memory leak.

s/avoid/to avoid a/

> 
> Suggested-by: Paolo Bonzini <address@hidden>
> Signed-off-by: Gonglei <address@hidden>
> ---
>  ui/spice-core.c | 12 +++++++-----
>  1 file changed, 7 insertions(+), 5 deletions(-)
> 

Maintainer can fix up commit message typos.
Reviewed-by: Eric Blake <address@hidden>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]