[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] target-mips: Tighten ISA level checks
|
From: |
Maciej W. Rozycki |
|
Subject: |
Re: [Qemu-devel] [PATCH] target-mips: Tighten ISA level checks |
|
Date: |
Wed, 3 Dec 2014 18:00:39 +0000 |
|
User-agent: |
Alpine 1.10 (DEB 962 2008-03-14) |
On Wed, 3 Dec 2014, Leon Alrae wrote:
> > - env->hflags |= MIPS_HFLAG_DM | MIPS_HFLAG_64 | MIPS_HFLAG_CP0;
> > + if (env->insn_flags & ISA_MIPS3)
> > + env->hflags |= MIPS_HFLAG_64;
>
> According to the CODING_STYLE braces are required even for a single
> statement "if" block. This also applies in other places in this patch.
These slipped through somehow, I must have forgotten to run checkpatch
on this change. Resending an updated version right away, thanks for
catching this up and for your review.
Maciej