[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] target-mips: Tighten ISA level checks
|
From: |
Leon Alrae |
|
Subject: |
Re: [Qemu-devel] [PATCH] target-mips: Tighten ISA level checks |
|
Date: |
Wed, 3 Dec 2014 17:46:41 +0000 |
|
User-agent: |
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 |
On 19/11/2014 14:20, Maciej W. Rozycki wrote:
> - env->hflags |= MIPS_HFLAG_DM | MIPS_HFLAG_64 | MIPS_HFLAG_CP0;
> + if (env->insn_flags & ISA_MIPS3)
> + env->hflags |= MIPS_HFLAG_64;
According to the CODING_STYLE braces are required even for a single
statement "if" block. This also applies in other places in this patch.
Otherwise,
Reviewed-by: Leon Alrae <address@hidden>
- Re: [Qemu-devel] [PATCH] target-mips: Tighten ISA level checks,
Leon Alrae <=