Re: [Qemu-devel] [PATCH v3 2/6] vmdk: Fix comment to match code of extent lines

[Max Reitz]

On 2014-12-03 at 11:28, Fam Zheng wrote:
> commit 04d542c8b (vmdk: support vmfs files) added support of VMFS extent
> type but the comment above the changed code is left out. Update the
> comment so they are consistent.
>
> Signed-off-by: Fam Zheng <address@hidden>
> Reviewed-by: Markus Armbruster <address@hidden>
> ---
>   block/vmdk.c | 5 +++--
>   1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/block/vmdk.c b/block/vmdk.c
> index ebb4b70..28d22db 100644
> --- a/block/vmdk.c
> +++ b/block/vmdk.c
> @@ -785,10 +785,11 @@ static int vmdk_parse_extents(const char *desc, 
> BlockDriverState *bs,
>       VmdkExtent *extent;
>   
>       while (*p) {
> -        /* parse extent line:
> +        /* parse extent line in one of below formats:
> +         *
>            * RW [size in sectors] FLAT "file-name.vmdk" OFFSET
> -         * or
>            * RW [size in sectors] SPARSE "file-name.vmdk"
> +         * RW [size in sectors] VMFS "file-name.vmdk"
>            */
>           flat_offset = -1;
>           ret = sscanf(p, "%10s %" SCNd64 " %10s \"%511[^\n\r\"]\" %" SCNd64,

Isn't VMFSSPARSE missing? It doesn't seem to be handled any different 
than SPARSE, but then again, VMFS isn't handled so differently than FLAT 
either (except it doesn't take an offset)...

Max