[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 11/22] iotests: Prepare for refcount_width op
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH v3 11/22] iotests: Prepare for refcount_width option |
Date: |
Fri, 28 Nov 2014 13:06:21 +0000 |
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Thu, Nov 20, 2014 at 06:06:27PM +0100, Max Reitz wrote:
> Some tests do not work well with certain refcount widths (i.e. you
> cannot create internal snapshots with refcount_width=1), so make those
> widths unsupported.
>
> Furthermore, add another filter to _filter_img_create in common.filter
> which filters out the refcount_width value.
>
> This is necessary for test 079, which does actually work with any
> refcount width, but invoking qemu-img directly leads to the
> refcount_width value being visible in the output; use _make_test_img
> instead which will filter it out.
>
> Signed-off-by: Max Reitz <address@hidden>
> Reviewed-by: Eric Blake <address@hidden>
> ---
> tests/qemu-iotests/007 | 3 +++
> tests/qemu-iotests/015 | 2 ++
> tests/qemu-iotests/026 | 7 +++++++
> tests/qemu-iotests/029 | 2 ++
> tests/qemu-iotests/051 | 3 +++
> tests/qemu-iotests/058 | 2 ++
> tests/qemu-iotests/067 | 2 ++
> tests/qemu-iotests/079 | 10 ++--------
> tests/qemu-iotests/079.out | 38 ++++++++++----------------------------
> tests/qemu-iotests/080 | 2 ++
> tests/qemu-iotests/089 | 2 ++
> tests/qemu-iotests/108 | 2 ++
> tests/qemu-iotests/common.filter | 3 ++-
> 13 files changed, 41 insertions(+), 37 deletions(-)
Reviewed-by: Stefan Hajnoczi <address@hidden>
pgp24kTNejhvJ.pgp
Description: PGP signature
- Re: [Qemu-devel] [PATCH v3 08/22] qcow2: More helpers for refcount modification, (continued)
- [Qemu-devel] [PATCH v3 09/22] qcow2: Open images with refcount order != 4, Max Reitz, 2014/11/20
- [Qemu-devel] [PATCH v3 10/22] qcow2: refcount_order parameter for qcow2_create2, Max Reitz, 2014/11/20
- [Qemu-devel] [PATCH v3 12/22] qcow2: Allow creation with refcount order != 4, Max Reitz, 2014/11/20
- [Qemu-devel] [PATCH v3 11/22] iotests: Prepare for refcount_width option, Max Reitz, 2014/11/20
- Re: [Qemu-devel] [PATCH v3 11/22] iotests: Prepare for refcount_width option,
Stefan Hajnoczi <=
- [Qemu-devel] [PATCH v3 13/22] progress: Allow regressing progress, Max Reitz, 2014/11/20
- [Qemu-devel] [PATCH v3 16/22] qcow2: Use abort() instead of assert(false), Max Reitz, 2014/11/20
- [Qemu-devel] [PATCH v3 15/22] qcow2: Use error_report() in qcow2_amend_options(), Max Reitz, 2014/11/20
- [Qemu-devel] [PATCH v3 14/22] block: Add opaque value to the amend CB, Max Reitz, 2014/11/20
- [Qemu-devel] [PATCH v3 17/22] qcow2: Split upgrade/downgrade paths for amend, Max Reitz, 2014/11/20