[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] block: do not use get_clock()
|
From: |
Markus Armbruster |
|
Subject: |
Re: [Qemu-devel] [PATCH] block: do not use get_clock() |
|
Date: |
Thu, 27 Nov 2014 18:45:28 +0100 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) |
Paolo Bonzini <address@hidden> writes:
> On 27/11/2014 10:19, Markus Armbruster wrote:
>> Paolo Bonzini <address@hidden> writes:
>>
>>> Use the external qemu-timer API instead.
>>
>> Ignorant question: why?
>
> Because no one else calls it directly, it is an internal function. I
> want to keep it confined to qemu-timer.c (and possibly cpus.c in the
> icount implementation, but maybe not even that is necessary).
That's a perfectly sensible reason. Please add it to the commit
message, so we have a more permanent record.
Of course, the best permanent record would be a static keyword :)