[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] ppc: do not use get_clock_realtime()
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH] ppc: do not use get_clock_realtime() |
Date: |
Thu, 27 Nov 2014 18:00:38 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 |
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 27/11/2014 01:51, Tony Breeds wrote:
> On Wed, Nov 26, 2014 at 03:01:01PM +0100, Paolo Bonzini wrote:
>> Use the external qemu-timer API instead.
>
> Perhaps it's obvious but is it reasonable to expand on why you're
> doign this in the commit message?
You're right. It's just that the API should be private to
qemu-timer.c, it is not meant for external usage---and it is messy
because get_clock_realtime() is for QEMU_CLOCK_HOST.
In addition, all uses of QEMU_CLOCK_HOST should probably use rtc_clock
instead, and this patch makes it easier to track those places for a
follow-up switch to rtc_clock.
Paolo
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
iQEcBAEBAgAGBQJUd1izAAoJEL/70l94x66D8ncH/jwc6oVfUjHvBau3GJy0Vi/I
S5kMndpPKgepMlAWWSK67uoMZQWAyRwG4Bwyat3g8RnpevQTN1pLZG276c2f5t5o
piB9nGmT7BPhxkEiWGGtxeX5ob1Ab8hhTm4Ai78fH8OnQexBT1B06Oz3zcYZKoGD
ckbCzEeiAb8Jxm4wop/s+WApqcnWAsfriCJ0XWUQxtxIbt3esmfMzW+n2fxvhHI1
ookJgqn1ssHpZBYu5lnsPxY+kVTrf0dQaeiPApGSmHUJknmnAEXUGKl1jsdjLCE2
8h5sasf3a7xL+GmZrYjzyZbLYm6BqmjNSsBYCFHYVYVFl857b/S1azoxPC5EZc0=
=4+yL
-----END PGP SIGNATURE-----