[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 05/22] qcow2: Refcount overflow and qcow2_all
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH v3 05/22] qcow2: Refcount overflow and qcow2_alloc_bytes() |
Date: |
Thu, 27 Nov 2014 14:59:27 +0000 |
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Thu, Nov 20, 2014 at 06:06:21PM +0100, Max Reitz wrote:
> qcow2_alloc_bytes() may reuse a cluster multiple times, in which case
> the refcount is increased accordingly. However, if this would lead to an
> overflow the function should instead just not reuse this cluster and
> allocate a new one.
>
> Signed-off-by: Max Reitz <address@hidden>
> Reviewed-by: Eric Blake <address@hidden>
> ---
> block/qcow2-refcount.c | 32 ++++++++++++++++++++++++++++++--
> 1 file changed, 30 insertions(+), 2 deletions(-)
Reviewed-by: Stefan Hajnoczi <address@hidden>
pgpEPrMJRkjsR.pgp
Description: PGP signature
- [Qemu-devel] [PATCH v3 00/22] qcow2: Support refcount orders != 4, Max Reitz, 2014/11/20
- [Qemu-devel] [PATCH v3 01/22] qcow2: Add two new fields to BDRVQcowState, Max Reitz, 2014/11/20
- [Qemu-devel] [PATCH v3 03/22] qcow2: Use 64 bits for refcount values, Max Reitz, 2014/11/20
- [Qemu-devel] [PATCH v3 04/22] qcow2: Respect error in qcow2_alloc_bytes(), Max Reitz, 2014/11/20
- [Qemu-devel] [PATCH v3 05/22] qcow2: Refcount overflow and qcow2_alloc_bytes(), Max Reitz, 2014/11/20
- Re: [Qemu-devel] [PATCH v3 05/22] qcow2: Refcount overflow and qcow2_alloc_bytes(),
Stefan Hajnoczi <=
- [Qemu-devel] [PATCH v3 06/22] qcow2: Helper for refcount array reallocation, Max Reitz, 2014/11/20
- [Qemu-devel] [PATCH v3 02/22] qcow2: Add refcount_width to format-specific info, Max Reitz, 2014/11/20
- [Qemu-devel] [PATCH v3 07/22] qcow2: Helper function for refcount modification, Max Reitz, 2014/11/20