[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v2 10/13] qcow2: Prevent numerical overflow
From: |
Max Reitz |
Subject: |
[Qemu-devel] [PATCH v2 10/13] qcow2: Prevent numerical overflow |
Date: |
Thu, 27 Nov 2014 15:48:37 +0100 |
In qcow2_alloc_cluster_offset(), *num is limited to
INT_MAX >> BDRV_SECTOR_BITS by all callers. However, since remaining is
of type uint64_t, we might as well cast *num to that type before
performing the shift.
Cc: address@hidden
Signed-off-by: Max Reitz <address@hidden>
---
block/qcow2-cluster.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/block/qcow2-cluster.c b/block/qcow2-cluster.c
index df0b2c9..1fea514 100644
--- a/block/qcow2-cluster.c
+++ b/block/qcow2-cluster.c
@@ -1263,7 +1263,7 @@ int qcow2_alloc_cluster_offset(BlockDriverState *bs,
uint64_t offset,
again:
start = offset;
- remaining = *num << BDRV_SECTOR_BITS;
+ remaining = (uint64_t)*num << BDRV_SECTOR_BITS;
cluster_offset = 0;
*host_offset = 0;
cur_bytes = 0;
--
1.9.3
- [Qemu-devel] [PATCH v2 00/13] block: Various Coverity-spotted fixes, Max Reitz, 2014/11/27
- [Qemu-devel] [PATCH v2 01/13] block: Make essential BlockDriver objects public, Max Reitz, 2014/11/27
- [Qemu-devel] [PATCH v2 02/13] block: Omit bdrv_find_format for essential drivers, Max Reitz, 2014/11/27
- [Qemu-devel] [PATCH v2 03/13] block/vvfat: qcow driver may not be found, Max Reitz, 2014/11/27
- [Qemu-devel] [PATCH v2 04/13] block/nfs: Add create_opts, Max Reitz, 2014/11/27
- [Qemu-devel] [PATCH v2 05/13] block: Check create_opts before image creation, Max Reitz, 2014/11/27
- [Qemu-devel] [PATCH v2 06/13] qemu-img: Check create_opts before image creation, Max Reitz, 2014/11/27
- [Qemu-devel] [PATCH v2 07/13] qemu-img: Check create_opts before image amendment, Max Reitz, 2014/11/27
- [Qemu-devel] [PATCH v2 08/13] iotests: Only kill NBD server if it runs, Max Reitz, 2014/11/27
- [Qemu-devel] [PATCH v2 09/13] iotests: Add test for unsupported image creation, Max Reitz, 2014/11/27
- [Qemu-devel] [PATCH v2 10/13] qcow2: Prevent numerical overflow,
Max Reitz <=
- [Qemu-devel] [PATCH v2 12/13] qcow2: Respect bdrv_truncate() error, Max Reitz, 2014/11/27
- [Qemu-devel] [PATCH v2 11/13] qcow2: Flushing the caches in qcow2_close may fail, Max Reitz, 2014/11/27
- [Qemu-devel] [PATCH v2 13/13] block/raw-posix: Fix ret in raw_open_common(), Max Reitz, 2014/11/27