[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 01/12] block: qcow2 driver may not be found
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-devel] [PATCH 01/12] block: qcow2 driver may not be found |
|
Date: |
Wed, 26 Nov 2014 08:19:14 -0700 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 |
On 11/26/2014 02:13 AM, Max Reitz wrote:
> On 2014-11-26 at 08:23, Markus Armbruster wrote:
>> Max Reitz <address@hidden> writes:
>>
>>> Albeit absolutely impossible right now, bdrv_find_format("qcow2") may
>>> fail. bdrv_append_temp_snapshot() should heed that case.
>> Impossible because we always compile in bdrv_qcow2.
>
>>> +++ b/block.c
>>> @@ -1320,6 +1320,12 @@ int bdrv_append_temp_snapshot(BlockDriverState
>>> *bs, int flags, Error **errp)
>>> }
>>> bdrv_qcow2 = bdrv_find_format("qcow2");
>>> + if (!bdrv_qcow2) {
Would it be shorter to 'assert(bdrv_qcow2);' to still silence Coverity?
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
[Qemu-devel] [PATCH 04/12] block: Check create_opts before image creation, Max Reitz, 2014/11/25
[Qemu-devel] [PATCH 05/12] qemu-img: Check create_opts before image creation, Max Reitz, 2014/11/25
[Qemu-devel] [PATCH 06/12] qemu-img: Check create_opts before image amendment, Max Reitz, 2014/11/25
[Qemu-devel] [PATCH 08/12] iotests: Add test for unsupported image creation, Max Reitz, 2014/11/25
[Qemu-devel] [PATCH 07/12] iotests: Only kill NBD server if it runs, Max Reitz, 2014/11/25
[Qemu-devel] [PATCH 09/12] qcow2: Prevent numerical overflow, Max Reitz, 2014/11/25
[Qemu-devel] [PATCH 10/12] qcow2: Flushing the caches in qcow2_close may fail, Max Reitz, 2014/11/25