[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH for-2.3 3/5] poll: Add epoll implementation for
From: |
Fam Zheng |
Subject: |
Re: [Qemu-devel] [PATCH for-2.3 3/5] poll: Add epoll implementation for qemu_poll |
Date: |
Wed, 26 Nov 2014 09:48:55 +0800 |
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Tue, 11/25 13:38, Stefan Hajnoczi wrote:
> On Tue, Nov 25, 2014 at 04:07:57PM +0800, Fam Zheng wrote:
> > +QEMUPoll *qemu_poll_new(void)
> > +{
> > + int epollfd;
> > + QEMUPoll *qpoll = g_new0(QEMUPoll, 1);
> > + epollfd = epoll_create1(EPOLL_CLOEXEC);
> > + if (epollfd < 0) {
> > + perror("epoll_create1:");
> > + abort();
> > + }
> > + qpoll->epollfd = epollfd;
> > + qpoll->max_events = 1;
> > + g_free(qpoll->events);
>
> What is the point of this g_free() call?
Bad rebase, I guess. Dropping.
Fam
- [Qemu-devel] [PATCH for-2.3 0/5] aio: Support epoll by introducing qemu_poll abstraction, Fam Zheng, 2014/11/25
- [Qemu-devel] [PATCH for-2.3 1/5] poll: Introduce QEMU Poll API, Fam Zheng, 2014/11/25
- [Qemu-devel] [PATCH for-2.3 3/5] poll: Add epoll implementation for qemu_poll, Fam Zheng, 2014/11/25
- [Qemu-devel] [PATCH for-2.3 2/5] posix-aio: Use QEMU poll interface, Fam Zheng, 2014/11/25
- [Qemu-devel] [PATCH for-2.3 4/5] main-loop: Replace qemu_poll_ns with qemu_poll, Fam Zheng, 2014/11/25
- [Qemu-devel] [PATCH for-2.3 5/5] tests: Add test case for qemu_poll, Fam Zheng, 2014/11/25
- Re: [Qemu-devel] [PATCH for-2.3 0/5] aio: Support epoll by introducing qemu_poll abstraction, Stefan Hajnoczi, 2014/11/25