[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] target-i386: add feature flags for CPUID[EAX=0x
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH] target-i386: add feature flags for CPUID[EAX=0xd, ECX=1] |
Date: |
Tue, 25 Nov 2014 21:02:38 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 |
On 25/11/2014 19:45, Eduardo Habkost wrote:
>> > +static const char *cpuid_xsave_feature_name[] = {
>> > + "xsaveopt", "xsavec", "xgetbv1", "xsaves",
> None of the above features introduce any new state that might need to be
> migrated, or will require other changes in QEMU to work, right?
>
> It looks like they don't introduce any extra state, but if they do, they
> need to be added to unmigratable_flags until migration support is
> implemented.
>
> If they require other QEMU changes, it would be nice if KVM reported
> them using KVM_CHECK_EXTENSION instead of GET_SUPPORTED_CPUID, so it
> wouldn't break "-cpu host".
No, they don't.
Paolo