[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2] hw/arm/realview.c: Fix memory leak in realvi
|
From: |
Markus Armbruster |
|
Subject: |
Re: [Qemu-devel] [PATCH v2] hw/arm/realview.c: Fix memory leak in realview_init() |
|
Date: |
Tue, 25 Nov 2014 14:02:00 +0100 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) |
Nikita Belov <address@hidden> writes:
> Variable 'ram_lo' is allocated unconditionally, but used only in some cases.
> When it is unused pointer will be lost at function exit, resulting in a
> memory leak. Allocate memory for 'ram_lo' only if it is needed.
>
> Valgrind output:
> ==16879== 240 bytes in 1 blocks are definitely lost in loss record 6,033 of
> 7,018
> ==16879== at 0x4C2AB80: malloc (in
> /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
> ==16879== by 0x33D2CE: malloc_and_trace (vl.c:2804)
> ==16879== by 0x509E610: g_malloc (in
> /lib/x86_64-linux-gnu/libglib-2.0.so.0.4000.0)
> ==16879== by 0x288836: realview_init (realview.c:55)
> ==16879== by 0x28988C: realview_pb_a8_init (realview.c:375)
> ==16879== by 0x341426: main (vl.c:4413)
>
> Signed-off-by: Nikita Belov <address@hidden>
Reviewed-by: Markus Armbruster <address@hidden>