[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v5 1/3] linux-aio: fix submit aio as a batch
|
From: |
Stefan Hajnoczi |
|
Subject: |
Re: [Qemu-devel] [PATCH v5 1/3] linux-aio: fix submit aio as a batch |
|
Date: |
Mon, 24 Nov 2014 16:40:23 +0000 |
|
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Mon, Nov 24, 2014 at 10:29:37PM +0800, Ming Lei wrote:
> + /* submit immediately if queue depth is above 2/3 */
> + if (idx > s->io_q.size * 2 / 3) {
> + return ioq_submit(s);
The return value of ioq_submit() is the number of requests submitted (0
or more). This has no meaning to the caller and therefore shouldn't be
the return value of this function.
Please drop the return here.
pgpGe726DE5TS.pgp
Description: PGP signature