[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 4/4] blockdev: check for BLOCK_OP_TYPE_EXTERNAL_
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH 4/4] blockdev: check for BLOCK_OP_TYPE_EXTERNAL_SNAPSHOT |
Date: |
Fri, 21 Nov 2014 12:58:56 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 |
On 21/11/2014 11:49, Stefan Hajnoczi wrote:
> The BLOCK_OP_TYPE_EXTERNAL_SNAPSHOT op blocker exists but was never
> used! Let's fix that so external snapshot can be blocked.
The patch is about internal snapshots tho. :)
Paolo
> Signed-off-by: Stefan Hajnoczi <address@hidden>
> ---
> blockdev.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/blockdev.c b/blockdev.c
> index 90cb33d..d63bb7f 100644
> --- a/blockdev.c
> +++ b/blockdev.c
> @@ -1236,6 +1236,10 @@ static void
> internal_snapshot_prepare(BlkTransactionState *common,
> return;
> }
>
> + if (bdrv_op_is_blocked(bs, BLOCK_OP_TYPE_INTERNAL_SNAPSHOT, errp)) {
> + return;
> + }
> +
> if (bdrv_is_read_only(bs)) {
> error_set(errp, QERR_DEVICE_IS_READ_ONLY, device);
> return;
>
- [Qemu-devel] [PATCH 0/4] blockdev: support dataplane in QMP 'transaction' command, Stefan Hajnoczi, 2014/11/21
- [Qemu-devel] [PATCH 1/4] blockdev: update outdated qmp_transaction() comments, Stefan Hajnoczi, 2014/11/21
- [Qemu-devel] [PATCH 3/4] blockdev: acquire AioContext in QMP 'transaction' actions, Stefan Hajnoczi, 2014/11/21
- [Qemu-devel] [PATCH 4/4] blockdev: check for BLOCK_OP_TYPE_EXTERNAL_SNAPSHOT, Stefan Hajnoczi, 2014/11/21
- [Qemu-devel] [PATCH 2/4] blockdev: drop unnecessary DriveBackupState field assignment, Stefan Hajnoczi, 2014/11/21
- Re: [Qemu-devel] [PATCH 0/4] blockdev: support dataplane in QMP 'transaction' command, Stefan Hajnoczi, 2014/11/26