[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] geometry: fix i386 compilation
From: |
Christian Borntraeger |
Subject: |
Re: [Qemu-devel] [PATCH] geometry: fix i386 compilation |
Date: |
Thu, 20 Nov 2014 17:30:17 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 |
Am 20.11.2014 um 17:18 schrieb Kevin Wolf:
> Am 19.11.2014 um 16:04 hat Cornelia Huck geschrieben:
>> On Wed, 19 Nov 2014 14:40:07 +0000
>> Peter Maydell <address@hidden> wrote:
>>
>>> On 19 November 2014 14:01, Ekaterina Tumanova
>>> <address@hidden> wrote:
>>>> Signed-off-by: Ekaterina Tumanova <address@hidden>
>>>
>>> Could you give the compiler error/warning message, please
>>> (and the compiler version)?
>>>
>>> These changes look sensible but it's not clear to me why
>>> the current code would cause a compilation failure or why
>>> that would be specific to i386...
>>
>> This patch is referring to Kate's patch set "[PATCH v2 0/6] Geometry
>> and blocksize support for backing devices", which did not compile on
>> i386 (see <address@hidden>).
>
> Where does it need to be squashed in? We want to keep the tree
> bisectable, so breaking the build and then fixing it at the end of the
> series isn't an option.
I think Kate just wanted to avoid spamming the list with v3 if only one
patch is fixed up when there was no review comment about the content of
the series. Using the -in-reply-to option plus a comment in the patch
would have avoided the confusion - I guess.
Christian
- Re: [Qemu-devel] [PATCH v2 5/6] geometry: Call backend function to detect geometry and blocksize, (continued)
Re: [Qemu-devel] [PATCH v2 5/6] geometry: Call backend function to detect geometry and blocksize, Markus Armbruster, 2014/11/28
[Qemu-devel] [PATCH v2 6/6] geometry: Target specific hook for s390x in geometry guessing, Ekaterina Tumanova, 2014/11/19
Re: [Qemu-devel] [PATCH v2 0/6] Geometry and blocksize support for backing devices, Christian Borntraeger, 2014/11/19
Re: [Qemu-devel] [PATCH] geometry: fix i386 compilation, Markus Armbruster, 2014/11/28
Re: [Qemu-devel] [PATCH v2 0/6] Geometry and blocksize support for backing devices, Christian Borntraeger, 2014/11/21
Re: [Qemu-devel] [PATCH v2 0/6] Geometry and blocksize support for backing devices, Stefan Hajnoczi, 2014/11/25
Re: [Qemu-devel] [PATCH v2 0/6] Geometry and blocksize support for backing devices, Stefan Hajnoczi, 2014/11/28
Re: [Qemu-devel] [PATCH v2 0/6] Geometry and blocksize support for backing devices, Markus Armbruster, 2014/11/28