Re: [Qemu-devel] [PATCH] pass semihosting exit code back to system

[Peter Maydell]

On 18 November 2014 19:29, Liviu Ionescu <address@hidden> wrote:
> Signed-off-by: Liviu Ionescu <address@hidden>
> ---
>  target-arm/arm-semi.c | 12 ++++++++++--
>  1 file changed, 10 insertions(+), 2 deletions(-)
>
> diff --git a/target-arm/arm-semi.c b/target-arm/arm-semi.c
> index ebb5235..4b982ad 100644
> --- a/target-arm/arm-semi.c
> +++ b/target-arm/arm-semi.c
> @@ -58,6 +58,11 @@
>  #define TARGET_SYS_HEAPINFO    0x16
>  #define TARGET_SYS_EXIT        0x18
>
> +/* ADP_Stopped_ApplicationExit is used for exit(0),
> + * anything else is implemented as exit(1) */
> +#define ADP_Stopped_ApplicationExit     ((2 << 16) + 38)
> +#define ADP_Stopped_RunTimeError        ((2 << 16) + 35)

The ARM documentation seems to define this value as
0x20026 rather than with a shift-and-decimal-value, so
I'd rather follow that. Otherwise this patch looks good.

Again, I can take the patch into my queue and fix this nit
as I do so, or you can reroll if you'd rather do it yourself.

thanks
-- PMM