qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] mips: Correct the writes to CP0 Status and Caus


From: Leon Alrae
Subject: Re: [Qemu-devel] [PATCH] mips: Correct the writes to CP0 Status and Cause registers via gdbstub
Date: Mon, 17 Nov 2014 14:32:18 +0000
User-agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0

Hi Maciej,

On 10/11/2014 13:46, Maciej W. Rozycki wrote:
> qemu-mips-status.diff
> Index: qemu-git-trunk/target-mips/cpu.h
> ===================================================================
> --- qemu-git-trunk.orig/target-mips/cpu.h     2014-11-09 23:44:32.000000000 
> +0000
> +++ qemu-git-trunk/target-mips/cpu.h  2014-11-09 23:49:54.997846651 +0000

Could you please include diffstat when you generate patches? (git
format-patch adds it by default). It makes review much easier -
especially of longer patches - as it immediately tells which files and
how many lines have been modified before starting looking at the actual
changes.

Thanks,
Leon




reply via email to

[Prev in Thread] Current Thread [Next in Thread]