[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 9/9] hcd-musb: fix dereference null return value
From: |
Gerd Hoffmann |
Subject: |
Re: [Qemu-devel] [PATCH 9/9] hcd-musb: fix dereference null return value |
Date: |
Mon, 17 Nov 2014 14:36:58 +0100 |
> >> @@ -625,8 +626,11 @@ static void musb_packet(MUSBState *s, MUSBEndPoint
> >> *ep,
> >> /* A wild guess on the FADDR semantics... */
> >> dev = usb_find_device(&s->port, ep->faddr[idx]);
> >> uep = usb_ep_get(dev, pid, ep->type[idx] & 0xf);
> >> - usb_packet_setup(&ep->packey[dir].p, pid, uep, 0,
> >> - (dev->addr << 16) | (uep->nr << 8) | pid, false,
> >> true);
> >> + id = pid;
> >> + if (uep) {
> >> + id |= (dev->addr << 16) | (uep->nr << 8);
> >> + }
> >> + usb_packet_setup(&ep->packey[dir].p, pid, uep, 0, id, false, true);
> >> usb_packet_addbuf(&ep->packey[dir].p, ep->buf[idx], len);
> >> ep->packey[dir].ep = ep;
> >> ep->packey[dir].dir = dir;
> >
> > This is a good approach, id is just a identifying. Thanks,
> >
>
> Let me split the patch from this series as a separate patch
> and add Paolo's signed-off-by.
>
> Asking for Gerd's reviewing, Thanks.
Looks good to me.
cheers,
Gerd
- [Qemu-devel] [PATCH 6/9] acl: fix memory leak, (continued)
- [Qemu-devel] [PATCH 6/9] acl: fix memory leak, arei.gonglei, 2014/11/15
- [Qemu-devel] [PATCH 5/9] nvme: remove superfluous check, arei.gonglei, 2014/11/15
- [Qemu-devel] [PATCH 4/9] loader: fix NEGATIVE_RETURNS, arei.gonglei, 2014/11/15
- [Qemu-devel] [PATCH 1/9] l2tpv3: fix fd leak, arei.gonglei, 2014/11/15
- [Qemu-devel] [PATCH 2/9] mips_mipssim: fix use-after-free for filename, arei.gonglei, 2014/11/15
- [Qemu-devel] [PATCH 9/9] hcd-musb: fix dereference null return value, arei.gonglei, 2014/11/15
[Qemu-devel] [PATCH 8/9] shpc: fix dead code, arei.gonglei, 2014/11/15