[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 2/2] virtfs-proxy-helper: Fix handle leak to make Co
From: |
arei.gonglei |
Subject: |
[Qemu-devel] [PATCH 2/2] virtfs-proxy-helper: Fix handle leak to make Coverity happy |
Date: |
Thu, 13 Nov 2014 20:17:07 +0800 |
From: Gonglei <address@hidden>
Coverity report:
(94) Event open_fn: Returning handle opened by function "proxy_socket(char
const *, uid_t, gid_t)". [details]
(95) Event var_assign: Assigning: "sock" = handle returned from
"proxy_socket(sock_name, own_u, own_g)".
(103) Event leaked_handle: Handle variable "sock" going out of scope leaks the
handle.
Signed-off-by: Gonglei <address@hidden>
---
fsdev/virtfs-proxy-helper.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/fsdev/virtfs-proxy-helper.c b/fsdev/virtfs-proxy-helper.c
index c1da2d7..2d72def 100644
--- a/fsdev/virtfs-proxy-helper.c
+++ b/fsdev/virtfs-proxy-helper.c
@@ -1150,6 +1150,9 @@ int main(int argc, char **argv)
process_requests(sock);
error:
+ if (sock_name && sock >= 0) {
+ close(sock);
+ }
do_log(LOG_INFO, "Done\n");
closelog();
return 0;
--
1.7.12.4
[Qemu-devel] [PATCH 1/2] virtfs-proxy-helper: Fix possible socket leak., arei.gonglei, 2014/11/13
Re: [Qemu-devel] [PATCH 0/2] virtfs-proxy-helper: Fix Coverity warning, Gonglei, 2014/11/27