[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] target-i386/fpu_helper.c: fbld instruction does
|
From: |
Richard Henderson |
|
Subject: |
Re: [Qemu-devel] [PATCH] target-i386/fpu_helper.c: fbld instruction doesn't set minus sign |
|
Date: |
Wed, 12 Nov 2014 08:43:57 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 |
On 11/11/2014 01:33 PM, Dmitry Poletaev wrote:
> ping
>
> 25.07.2014, 15:48, "Dmitry Poletaev" <address@hidden>:
>> Obviously, there is a misprint in function implementation.
>>
>> From: Dmitry Poletaev <address@hidden>
>> Signed-off-by: Dmitry Poletaev <address@hidden>
>>
>> ---
>> target-i386/fpu_helper.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/target-i386/fpu_helper.c b/target-i386/fpu_helper.c
>> index 1b2900d..be1e545 100644
>> --- a/target-i386/fpu_helper.c
>> +++ b/target-i386/fpu_helper.c
>> @@ -622,7 +622,7 @@ void helper_fbld_ST0(CPUX86State *env, target_ulong ptr)
>> }
>> tmp = int64_to_floatx80(val, &env->fp_status);
>> if (cpu_ldub_data(env, ptr + 9) & 0x80) {
>> - floatx80_chs(tmp);
>> + tmp = floatx80_chs(tmp);
>> }
>> fpush(env);
>> ST0 = tmp;
Reviewed-by: Richard Henderson <address@hidden>
r~