[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 20/21] qcow2: Point to amend function in check
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 20/21] qcow2: Point to amend function in check |
Date: |
Tue, 11 Nov 2014 21:38:25 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 |
On 11/10/2014 06:45 AM, Max Reitz wrote:
> If a reference count is not representable with the current refcount
> order, the image check should point to qemu-img amend for increasing the
> refcount order. However, qemu-img amend needs write access to the image
> which cannot be provided if the image is marked corrupt; and the image
> check will not mark the image consistent unless everything actually is
> consistent.
>
> Therefore, if an image is marked corrupt and the image check encounters
> a reference count overflow, it cannot be fixed by using qemu-img amend
> to increase the refcount order. Instead, one has to use qemu-img convert
> to create a completely new copy of the image in this case.
>
> Alternatively, we may want to give the user a way of manually removing
> the corrupt flag, maybe through qemu-img amend, but this is not part of
> this patch.
>
> Signed-off-by: Max Reitz <address@hidden>
> ---
> block/qcow2-refcount.c | 3 +++
> 1 file changed, 3 insertions(+)
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
[Qemu-devel] [PATCH 19/21] qcow2: Invoke refcount order amendment function, Max Reitz, 2014/11/10
[Qemu-devel] [PATCH 20/21] qcow2: Point to amend function in check, Max Reitz, 2014/11/10
- Re: [Qemu-devel] [PATCH 20/21] qcow2: Point to amend function in check,
Eric Blake <=
[Qemu-devel] [PATCH 21/21] iotests: Add test for different refcount widths, Max Reitz, 2014/11/10