Re: [Qemu-devel] [PATCH 15/21] qcow2: Use abort() instead of assert(false)

[Eric Blake]

On 11/10/2014 06:45 AM, Max Reitz wrote:
> Signed-off-by: Max Reitz <address@hidden>
> ---
>  block/qcow2.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Reviewed-by: Eric Blake <address@hidden>

Is it worth hoisting this one into 2.2 via the -trivial tree?

> 
> diff --git a/block/qcow2.c b/block/qcow2.c
> index beb7187..ebf843f 100644
> --- a/block/qcow2.c
> +++ b/block/qcow2.c
> @@ -2718,9 +2718,9 @@ static int qcow2_amend_options(BlockDriverState *bs, 
> QemuOpts *opts,
>              error_report("Cannot change refcount entry width");
>              return -ENOTSUP;
>          } else {
> -            /* if this assertion fails, this probably means a new option was
> +            /* if this point is reached, this probably means a new option was
>               * added without having it covered here */
> -            assert(false);
> +            abort();
>          }
>  
>          desc++;
> 

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature