Re: [Qemu-devel] [RFC PATCH v4 02/25] mc146818rtc: add missed field to vmstate

[Paolo Bonzini]

On 07/11/2014 11:31, Pavel Dovgalyuk wrote:
> This patch adds irq_reinject_on_ack_count field to VMState to allow correct
> saving/loading the state of MC146818 RTC.
> 
> Signed-off-by: Pavel Dovgalyuk <address@hidden>
> ---
>  hw/timer/mc146818rtc.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/hw/timer/mc146818rtc.c b/hw/timer/mc146818rtc.c
> index f18d128..2c4b650 100644
> --- a/hw/timer/mc146818rtc.c
> +++ b/hw/timer/mc146818rtc.c
> @@ -809,6 +809,7 @@ static void rtc_reset(void *opaque)
>  
>      s->cmos_data[RTC_REG_B] &= ~(REG_B_PIE | REG_B_AIE | REG_B_SQWE);
>      s->cmos_data[RTC_REG_C] &= ~(REG_C_UF | REG_C_IRQF | REG_C_PF | 
> REG_C_AF);
> +    s->irq_reinject_on_ack_count = 0;
>      check_update_timer(s);
>  
>      qemu_irq_lower(s->irq);
> 

This is already set below.  If you need it here, please justify it in
the commit message and move up the code that already sets it.

Paolo