[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] vl: rework smp_parse
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH] vl: rework smp_parse |
Date: |
Thu, 06 Nov 2014 23:11:30 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 |
On 06/11/2014 17:09, Andrew Jones wrote:
> + if (sockets * cores * threads != max_cpus) {
> + fprintf(stderr, "cpu topology: "
> + "sockets (%u) * cores (%u) * threads (%u) != max_cpus
> (%u)\n",
> + sockets, cores, threads, max_cpus);
> + exit(1);
> + }
I think this would cause too many failures in the wild. Perhaps error
out if it is lower, and warn if sockets * cores * threads > max_cpus
since we actually allow hot-plug a thread at a time?
Paolo
- [Qemu-devel] [PATCH] vl: rework smp_parse, Andrew Jones, 2014/11/06
- Re: [Qemu-devel] [PATCH] vl: rework smp_parse, Eduardo Habkost, 2014/11/06
- Re: [Qemu-devel] [PATCH] vl: rework smp_parse,
Paolo Bonzini <=
- Re: [Qemu-devel] [PATCH] vl: rework smp_parse, Andrew Jones, 2014/11/07
- Re: [Qemu-devel] [PATCH] vl: rework smp_parse, Paolo Bonzini, 2014/11/07
- Re: [Qemu-devel] [PATCH] vl: rework smp_parse, Andrew Jones, 2014/11/07
- Re: [Qemu-devel] [PATCH] vl: rework smp_parse, Andrew Jones, 2014/11/07
- Re: [Qemu-devel] [PATCH] vl: rework smp_parse, Eduardo Habkost, 2014/11/07
- Re: [Qemu-devel] [PATCH] vl: rework smp_parse, Andrew Jones, 2014/11/07
- Re: [Qemu-devel] [PATCH] vl: rework smp_parse, Eduardo Habkost, 2014/11/07
Re: [Qemu-devel] [PATCH] vl: rework smp_parse, Andrew Jones, 2014/11/07