Re: [Qemu-devel] [PATCH] qemu-char: fix tcp_get_fds

[Michael S. Tsirkin]

On Mon, Nov 03, 2014 at 04:22:57PM +0000, Peter Maydell wrote:
> On 3 November 2014 16:13, Markus Armbruster <address@hidden> wrote:
> > "Michael S. Tsirkin" <address@hidden> writes:
> >
> >> On Mon, Nov 03, 2014 at 04:09:36PM +0100, Markus Armbruster wrote:
> >>> "Michael S. Tsirkin" <address@hidden> writes:
> >>>
> >>> > tcp_get_fds API discards fds if there's more than 1 of these.
> >>>
> >>> s/tcp_get_fds/tcp_get_msgfds/ (subject as well)
> >>
> >> Right. Too late as I sent this upstream :(
> >
> > Oh, now I see: you already sent this in a pull request, after less than
> > 20 hours on list.  Please don't do that except in dire emergency.  It
> > sabotages our review process.
> 
> ...I haven't actually applied that yet, though. Since this
> isn't a critical bugfix I think it would probably be reasonable
> to respin the pull without this patch, so it has a bit more
> chance for review. Since it's not a new feature there's no
> need to rush to get it in before hardfreeze, right?
> 
> -- PMM

Okay.