Re: [Qemu-devel] [PATCH] qemu-char: fix tcp_get_fds

[Markus Armbruster]

"Michael S. Tsirkin" <address@hidden> writes:

> On Mon, Nov 03, 2014 at 04:09:36PM +0100, Markus Armbruster wrote:
>> "Michael S. Tsirkin" <address@hidden> writes:
>> 
>> > tcp_get_fds API discards fds if there's more than 1 of these.
>> 
>> s/tcp_get_fds/tcp_get_msgfds/ (subject as well)
>
> Right. Too late as I sent this upstream :(

Why not simply respin with a fixed commit message?  Or ask the
maintainer to fix it up on commit?

>> What exactly doesn't work without this patch?
>
> It's only used by vhost test. It works by chance because
> it's only using 512m ram.

Would be a nice addition to the commit message.

> I tweaked vhost user test
> to use more memory (3900 instead of 512 M) and it started failing
> because it needs 3 fds then.
>
> Not yet upstreaming the test change itself, looking
> for ways to avoid using huge pages for this.

Okay :)

[...]