qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v4 19/47] Rework loadvm path for subloops


From: David Gibson
Subject: Re: [Qemu-devel] [PATCH v4 19/47] Rework loadvm path for subloops
Date: Mon, 3 Nov 2014 16:08:19 +1100
User-agent: Mutt/1.5.23 (2014-03-12)

On Fri, Oct 03, 2014 at 06:47:25PM +0100, Dr. David Alan Gilbert (git) wrote:
> From: "Dr. David Alan Gilbert" <address@hidden>
> 
> Postcopy needs to have two migration streams loading concurrently;
> one from memory (with the device state) and the other from the fd
> with the memory transactions.
> 
> Split the core of qemu_loadvm_state out so we can use it for both.
> 
> Allow the inner loadvm loop to quit and signal whether the parent
> should.
> 
> loadvm_handlers is made static since it's lifetime is greater
> than the outer qemu_loadvm_state.

Maybe it's just me, but "made static" to me indicates either a change
from fully-global to module-global, or (function) local automatic to
local static, not a change from function local-automatic to
module-global as here.

It's also not clear from this patch alone why the lifetime of
loadvm_handlers now needs to exceed that of qemu_loadvm_state().

-- 
David Gibson                    | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au  | minimalist, thank you.  NOT _the_ _other_
                                | _way_ _around_!
http://www.ozlabs.org/~dgibson

Attachment: pgpBynolpuMlM.pgp
Description: PGP signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]