[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/3] Start moving migration code into a migratio
From: |
Amit Shah |
Subject: |
Re: [Qemu-devel] [PATCH 1/3] Start moving migration code into a migration directory |
Date: |
Thu, 30 Oct 2014 18:16:27 +0530 |
On (Thu) 30 Oct 2014 [12:37:27], Dr. David Alan Gilbert wrote:
> * Amit Shah (address@hidden) wrote:
> > On (Thu) 16 Oct 2014 [08:53:52], Dr. David Alan Gilbert (git) wrote:
> >
> > > rename migration-exec.c => migration/migration-exec.c (100%)
> > > rename migration-fd.c => migration/migration-fd.c (100%)
> > > rename migration-rdma.c => migration/migration-rdma.c (100%)
> > > rename migration-tcp.c => migration/migration-tcp.c (100%)
> > > rename migration-unix.c => migration/migration-unix.c (100%)
> > > rename migration.c => migration/migration.c (100%)
> >
> > I'm wondering if we should also use the opportunity to cleanup the
> > file names:
> >
> > migration.c => main.c
> > migration-X.c => X.c
> >
> > ?
>
> I'd be OK with changing filenames, but they would have to
> be fairly clear; I don't like having a 'main.c' because that's
> where I'd expect to find a main() - but we do have a few core.c's
> as the core of each of a few hw subdirs.
I think main should be OK in a subdir, because it's the main file for
that subsystem (not necessarily the whole program). Checking the src
for main.c, though, it looks like no one uses it in such a way (Linux
has lots of these, btw, hence my initial suggestion).
core.c is fine, too.
Amit
[Qemu-devel] [PATCH 2/3] Split struct QEMUFile out, Dr. David Alan Gilbert (git), 2014/10/16
[Qemu-devel] [PATCH 3/3] Split the QEMU buffered file code out, Dr. David Alan Gilbert (git), 2014/10/16