[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 04/20] target-mips: add 16, 64 bit load and s
From: |
Leon Alrae |
Subject: |
Re: [Qemu-devel] [PATCH v2 04/20] target-mips: add 16, 64 bit load and store |
Date: |
Wed, 29 Oct 2014 22:56:53 +0000 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:8.0) Gecko/20111124 Thunderbird/8.0 |
On 29/10/14 01:41, Yongbok Kim wrote:
>
> Signed-off-by: Yongbok Kim <address@hidden>
> ---
> target-mips/op_helper.c | 7 +++----
> 1 files changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/target-mips/op_helper.c b/target-mips/op_helper.c
> index 7cbf4cf..e878442 100644
> --- a/target-mips/op_helper.c
> +++ b/target-mips/op_helper.c
> @@ -90,10 +90,10 @@ static inline type do_##name(CPUMIPSState *env,
> target_ulong addr, \
> } \
> }
> #endif
> +HELPER_LD(lbu, ldub, uint8_t)
> +HELPER_LD(lhu, lduw, uint16_t)
> HELPER_LD(lw, ldl, int32_t)
> -#ifdef TARGET_MIPS64
> HELPER_LD(ld, ldq, int64_t)
> -#endif
> #undef HELPER_LD
>
> #if defined(CONFIG_USER_ONLY)
> @@ -118,10 +118,9 @@ static inline void do_##name(CPUMIPSState *env,
> target_ulong addr, \
> }
> #endif
> HELPER_ST(sb, stb, uint8_t)
> +HELPER_ST(sh, stw, uint16_t)
> HELPER_ST(sw, stl, uint32_t)
> -#ifdef TARGET_MIPS64
> HELPER_ST(sd, stq, uint64_t)
> -#endif
> #undef HELPER_ST
>
> target_ulong helper_clo (target_ulong arg1)
I agree with James, you could squash it into the patch which uses these
functions. Anyway,
Reviewed-by: Leon Alrae <address@hidden>
- Re: [Qemu-devel] [PATCH v2 02/20] target-mips: add MSA exceptions, (continued)
- [Qemu-devel] [PATCH v2 01/20] target-mips: add MSA defines and data structure, Yongbok Kim, 2014/10/28
- [Qemu-devel] [PATCH v2 03/20] target-mips: remove duplicated mips/ieee mapping function, Yongbok Kim, 2014/10/28
- [Qemu-devel] [PATCH v2 05/20] target-mips: stop translation after ctc1, Yongbok Kim, 2014/10/28
- [Qemu-devel] [PATCH v2 04/20] target-mips: add 16, 64 bit load and store, Yongbok Kim, 2014/10/28
- [Qemu-devel] [PATCH v2 06/20] target-mips: add MSA opcode enum, Yongbok Kim, 2014/10/28
- [Qemu-devel] [PATCH v2 07/20] target-mips: add msa_reset(), global msa register, Yongbok Kim, 2014/10/28
- [Qemu-devel] [PATCH v2 08/20] target-mips: add msa_helper.c, Yongbok Kim, 2014/10/28
- [Qemu-devel] [PATCH v2 09/20] target-mips: add MSA branch instructions, Yongbok Kim, 2014/10/28
- [Qemu-devel] [PATCH v2 10/20] target-mips: add MSA I8 format instructions, Yongbok Kim, 2014/10/28