[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] arm: fix TB alignment check
|
From: |
Leon Alrae |
|
Subject: |
Re: [Qemu-devel] [PATCH] arm: fix TB alignment check |
|
Date: |
Fri, 24 Oct 2014 17:08:09 +0100 |
|
User-agent: |
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 |
On 23/10/2014 17:15, Richard Henderson wrote:
> [3] Hello, MIPS. Leon, the test for mips is (now) incorrect:
>
> if ((ctx.pc & (TARGET_PAGE_SIZE - 1)) == 0)
> break;
>
> may never succeed for mips16 and micromips.
Indeed, this test doesn't look right (although I'm not sure what exactly
are the consequences if the test doesn't succeed and we span two or more
pages). Thanks for spotting this in MIPS.
Regards,
Leon