[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] vnc: fix fd leak at vnc_display_open()
From: |
Gonglei |
Subject: |
Re: [Qemu-devel] [PATCH] vnc: fix fd leak at vnc_display_open() |
Date: |
Thu, 23 Oct 2014 16:05:46 +0800 |
User-agent: |
Mozilla/5.0 (Windows NT 6.1; rv:11.0) Gecko/20120327 Thunderbird/11.0.1 |
On 2014/10/23 15:57, Gerd Hoffmann wrote:
> On Do, 2014-10-23 at 14:33 +0800, address@hidden wrote:
>> From: Gonglei <address@hidden>
>>
>> When using qmp change vnc interface, will leak fd
>> of vs->lsock and vs->lwebsock (if configed). Close
>> them before: re-evaluate.
>
> Ah, the file handles are leaked because you dropped the
> vnc_display_close() call. Don't do that then ...
>
Oops, understand. Sorry for the noise :(
What's your suggestion about the problem described in cover-letter? Gerd
Best regards,
-Gonglei