[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 3/4] get_maintainer.pl: move git loop under "if ($em
From: |
Paolo Bonzini |
Subject: |
[Qemu-devel] [PATCH 3/4] get_maintainer.pl: move git loop under "if ($email) {" |
Date: |
Wed, 22 Oct 2014 11:08:21 +0200 |
All checks in the loop are guarded by that condition, and there is a
handy "if" just below. Simplify the code.
Signed-off-by: Paolo Bonzini <address@hidden>
---
scripts/get_maintainer.pl | 19 +++++++++----------
1 file changed, 9 insertions(+), 10 deletions(-)
diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl
index 6c5a73b..7c6d186 100755
--- a/scripts/get_maintainer.pl
+++ b/scripts/get_maintainer.pl
@@ -632,18 +632,17 @@ sub get_maintainers {
$email->[0] = deduplicate_email($email->[0]);
}
- foreach my $file (@files) {
- if ($email &&
- ($email_git || ($email_git_fallback &&
- !$exact_pattern_match_hash{$file}))) {
- vcs_file_signoffs($file);
- }
- if ($email && $email_git_blame) {
- vcs_file_blame($file);
+ if ($email) {
+ foreach my $file (@files) {
+ if ($email_git || ($email_git_fallback &&
+ !$exact_pattern_match_hash{$file})) {
+ vcs_file_signoffs($file);
+ }
+ if ($email_git_blame) {
+ vcs_file_blame($file);
+ }
}
- }
- if ($email) {
foreach my $chief (@penguin_chief) {
if ($chief =~ m/^(.*):(.*)/) {
my $email_address;
--
1.8.3.1
- [Qemu-devel] [PATCH 0/4] small improvements to get_maintainer.pl, Paolo Bonzini, 2014/10/22
- [Qemu-devel] [PATCH 1/4] get_maintainer.pl: exit with status 1 if no maintainer found, Paolo Bonzini, 2014/10/22
- [Qemu-devel] [PATCH 3/4] get_maintainer.pl: move git loop under "if ($email) {",
Paolo Bonzini <=
- [Qemu-devel] [PATCH 4/4] get_maintainer.pl: point at --git-fallback instead of enabling it automatically, Paolo Bonzini, 2014/10/22
- Re: [Qemu-devel] [PATCH 4/4] get_maintainer.pl: point at --git-fallback instead of enabling it automatically, Michael S. Tsirkin, 2014/10/22
- Re: [Qemu-devel] [PATCH 4/4] get_maintainer.pl: point at --git-fallback instead of enabling it automatically, Paolo Bonzini, 2014/10/22
- Re: [Qemu-devel] [PATCH 4/4] get_maintainer.pl: point at --git-fallback instead of enabling it automatically, Thomas Huth, 2014/10/22
- Re: [Qemu-devel] [PATCH 4/4] get_maintainer.pl: point at --git-fallback instead of enabling it automatically, Michael S. Tsirkin, 2014/10/22
- Re: [Qemu-devel] [PATCH 4/4] get_maintainer.pl: point at --git-fallback instead of enabling it automatically, Paolo Bonzini, 2014/10/22
- Re: [Qemu-devel] [PATCH 4/4] get_maintainer.pl: point at --git-fallback instead of enabling it automatically, Markus Armbruster, 2014/10/22
[Qemu-devel] [PATCH 2/4] get_maintainer.pl: treat all M entries the same, Paolo Bonzini, 2014/10/22
Re: [Qemu-devel] [PATCH 0/4] small improvements to get_maintainer.pl, Thomas Huth, 2014/10/22