Re: [Qemu-devel] [PULL 13/23] q35/ahci: Pick up -cdrom and -hda options

[Peter Maydell]

On 17 October 2014 19:02, Peter Maydell <address@hidden> wrote:
> On 17 October 2014 18:57, Michael Tokarev <address@hidden> wrote:
>> On 10/17/2014 08:53 PM, Peter Maydell wrote:
>>> g_assert_cmpint() was only added in glib 2.16, so this won't
>>> build on glib 2.12. A compat fudge in glib-compat.h should
>>> be easy, though.
>>
>> Or just change this to regular in-line comparison and g_assert().
>
> There are a ton of uses in the tests/ directory as well, though.
> It would be nice if we could "make check" RHEL5 as well as just
> building it...

...however, all the g_test_* APIs were only added in glib 2.12,
so we're never going to be able to get 'make check' running there.
Let's just fix this one instance so our build works (or will work
when the spapr hashtable issue is fixed too).

-- PMM