[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] target-i386/FPU: wrong conversion infinity from
|
From: |
Peter Maydell |
|
Subject: |
Re: [Qemu-devel] [PATCH] target-i386/FPU: wrong conversion infinity from float80 to int32/int64 |
|
Date: |
Tue, 14 Oct 2014 12:55:53 +0200 |
On 14 October 2014 12:38, Dmitry Poletaev <address@hidden> wrote:
> 29.07.2014, 23:07, "Richard Henderson" <address@hidden>:
>> On 07/23/2014 05:04 AM, Dmitry Poletaev wrote:
>>> + if (env->fp_status.float_exception_flags & FPUS_IE) {
>>
>> Mixing bit masks. s/FPUS_IE/float_status_invalid/
[Please don't top-post.]
> What do you mean?
Richard means that the set of defined flags for
float_exception_flags does not include "FPUS_IE"
(which is defining a symbolic constant for a bit
in an x86 register). You want to use "float_flag_invalid".
(The two happen to have the same value, 1, which is why
your code worked by accident.)
thanks
-- PMM