[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v5 08/11] qcow2: Rebuild refcount structure duri
|
From: |
Benoît Canet |
|
Subject: |
Re: [Qemu-devel] [PATCH v5 08/11] qcow2: Rebuild refcount structure during check |
|
Date: |
Sat, 11 Oct 2014 18:56:25 +0000 |
|
User-agent: |
Mutt/1.5.21 (2010-09-15) |
> + int64_t first_free_cluster = 0, rt_ofs = -1, cluster = 0;
> + int64_t rb_ofs, rb_start, rb_index;
Everytime a few day pass and I read rb_ofs and rt_ofs again I found these names
obfuscated. I know Linus says that C is a spartan language but these look odd.
Maybe refcount_block_offset, refcount_block_* and refcount_table_offset would be
better.
I'll try to read this patch for real before you repost it.
Best regards
Benoît