Re: [Qemu-devel] Fullscreen Bug with GTK

[Cole Robinson]

On 10/06/2014 07:24 AM, Peter Maydell wrote:
> On 6 October 2014 11:28, Gerd Hoffmann <address@hidden> wrote:
>> On Mo, 2014-10-06 at 12:14 +0200, Cedric Sodhi wrote:
>>> The reporter explicitly mentioned that removing the Menu disables the
>>> Accels and therefore he has provided a patch which attaches the Accels
>>> to the Window instead (which, in fact, is how it should be done).
>>
>> Oh, missed that detail.  /me recommends submitting the patches to
>> qemu-devel then (and cc me so I don't miss them).
> 
> ...with the appropriate signed-off-by lines, which are
> missing from the patch in the bug.
> 

The patches in the original report were not meant to be submitted as is, and
instead I hoped it would start a discussion, because they depend on APIs only
available with gtk3.8, and the fallback loses some usefulness.

Also the example patch isn't complete, since I think we would want to install
all the accelerators on the parent window, rather than just the fullscreen
one. Then in fullscreen mode, every accelerator would continue to work, which
matches SDL behavior IIRC. I think if someone fleshed out my patch examples it
should be fine for them to use their own Signed-off-by. I don't have any plans
to submit a patch myself in the short term.

Also there's other possible approaches. Like disabling accelerators entirely
when in fullscreen mode, and instead use a hiding toolbar like virt-manager
and virt-viewer do. danpb pointed out that gtk 3.10 has a GtkRevealer widget
that could probably be used for that without having to import the autodrawer
code that virt-viewer uses.

- Cole