[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/1] hmp: Remove "info pcmcia"
|
From: |
Luiz Capitulino |
|
Subject: |
Re: [Qemu-devel] [PATCH 1/1] hmp: Remove "info pcmcia" |
|
Date: |
Thu, 9 Oct 2014 09:47:51 -0400 |
On Wed, 01 Oct 2014 10:54:44 +0200
Markus Armbruster <address@hidden> wrote:
> Ping?
>
> Markus Armbruster <address@hidden> writes:
>
> > This command lists PCMCIA sockets and cards. Only a few ARM boards
> > have sockets (akita, borzoi, connex, mainstone, spitz, terrier, tosa,
> > verdex, z2), the only card is the DSCM-1xxxx Hitachi Microdrive (qdev
> > "microdrive"), and it is only inserted during machine init, if ever.
> > So this command doesn't really tell anybody anything new so far.
> >
> > Moreover, pcmcia_socket_unregister() has a use-after-free bug, flagged
> > by Coverity. Has never been used, because there has never been code
> > to eject a PCMCIA card.
> >
> > Not worth fixing & converting to QMP. Remove it.
Sorry for the long delay on this one. But this patch is more about PCMCIA
support in QEMU than HMP, so I can provide my ACK, but I don't think this
is HMP material.
Acked-by: Luiz Capitulino <address@hidden>