[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 20/23] blockdev-test: Clean up bogus drive_add argume
From: |
Stefan Hajnoczi |
Subject: |
[Qemu-devel] [PULL 20/23] blockdev-test: Clean up bogus drive_add argument |
Date: |
Sat, 4 Oct 2014 21:24:46 +0100 |
From: Markus Armbruster <address@hidden>
The first argument should be a PCI address, which pci-addr=auto isn't.
Doesn't really matter, as drive_add ignores its first argument when
its second argument has if=none. Clean it up anyway.
Signed-off-by: Markus Armbruster <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Message-id: address@hidden
Signed-off-by: Stefan Hajnoczi <address@hidden>
---
tests/drive_del-test.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/drive_del-test.c b/tests/drive_del-test.c
index a5de239..32516a2 100644
--- a/tests/drive_del-test.c
+++ b/tests/drive_del-test.c
@@ -83,7 +83,7 @@ static void test_after_failed_device_add(void)
*/
response = qmp("{'execute': 'human-monitor-command',"
" 'arguments': {"
- " 'command-line': 'drive_add pci-addr=auto
if=none,id=drive0'"
+ " 'command-line': 'drive_add 0 if=none,id=drive0'"
"}}");
g_assert(response);
g_assert_cmpstr(qdict_get_try_str(response, "return"), ==, "OK\r\n");
--
1.9.3
- [Qemu-devel] [PULL 11/23] ide: Update ide_drive_get to be HBA agnostic, (continued)
- [Qemu-devel] [PULL 11/23] ide: Update ide_drive_get to be HBA agnostic, Stefan Hajnoczi, 2014/10/04
- [Qemu-devel] [PULL 12/23] qtest/bios-tables: Correct Q35 command line, Stefan Hajnoczi, 2014/10/04
- [Qemu-devel] [PULL 10/23] pc/vl: Add units-per-default-bus property, Stefan Hajnoczi, 2014/10/04
- [Qemu-devel] [PULL 13/23] q35/ahci: Pick up -cdrom and -hda options, Stefan Hajnoczi, 2014/10/04
- [Qemu-devel] [PULL 14/23] util: Emancipate id_wellformed() from QemuOpts, Stefan Hajnoczi, 2014/10/04
- [Qemu-devel] [PULL 15/23] iotests: Use _img_info, Stefan Hajnoczi, 2014/10/04
- [Qemu-devel] [PULL 17/23] iotests: qemu-img info output for corrupt image, Stefan Hajnoczi, 2014/10/04
- [Qemu-devel] [PULL 16/23] qapi: Add corrupt field to ImageInfoSpecificQCow2, Stefan Hajnoczi, 2014/10/04
- [Qemu-devel] [PULL 18/23] drive_del-test: Merge of qdev-monitor-test, blockdev-test, Stefan Hajnoczi, 2014/10/04
- [Qemu-devel] [PULL 19/23] blockdev-test: Use single rather than double quotes in QMP, Stefan Hajnoczi, 2014/10/04
- [Qemu-devel] [PULL 20/23] blockdev-test: Clean up bogus drive_add argument,
Stefan Hajnoczi <=
- [Qemu-devel] [PULL 21/23] blockdev-test: Simplify by using g_assert_cmpstr(), Stefan Hajnoczi, 2014/10/04
- [Qemu-devel] [PULL 22/23] blockdev-test: Factor out some common code into helpers, Stefan Hajnoczi, 2014/10/04
- [Qemu-devel] [PULL 23/23] blockdev-test: Test device_del after drive_del, Stefan Hajnoczi, 2014/10/04
- Re: [Qemu-devel] [PULL 00/23] Block patches, Peter Maydell, 2014/10/06