[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/6] drive_del-test: Merge of qdev-monitor-test,
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH 1/6] drive_del-test: Merge of qdev-monitor-test, blockdev-test |
Date: |
Thu, 02 Oct 2014 18:20:13 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) |
Eric Blake <address@hidden> writes:
> On 10/02/2014 08:51 AM, Markus Armbruster wrote:
>> Each of qdev-monitor-test and blockdev-test has just one test case,
>> and both are about drive_del.
>>
>> Signed-off-by: Markus Armbruster <address@hidden>
>> ---
>> tests/Makefile | 5 +--
>> tests/blockdev-test.c | 59 -------------------------
>> tests/{qdev-monitor-test.c => drive_del-test.c} | 57
>> +++++++++++++++++++-----
>> 3 files changed, 47 insertions(+), 74 deletions(-)
>> delete mode 100644 tests/blockdev-test.c
>> rename tests/{qdev-monitor-test.c => drive_del-test.c} (56%)
>
> Reviewed-by: Eric Blake <address@hidden>
>
>
>> --- a/tests/qdev-monitor-test.c
>> +++ b/tests/drive_del-test.c
>> @@ -1,5 +1,5 @@
>> /*
>> - * qdev-monitor.c test cases
>> + * blockdev.c test cases
>> *
>> * Copyright (C) 2013 Red Hat Inc.
>
> Worth bumping this to include 2014 while at it?
Sure, if I have to respin anyway.
Thanks!
- Re: [Qemu-devel] [PATCH 2/6] blockdev-test: Use single rather than double quotes in QMP, (continued)
- [Qemu-devel] [PATCH 5/6] blockdev-test: Factor out some common code into helpers, Markus Armbruster, 2014/10/02
- [Qemu-devel] [PATCH 6/6] blockdev-test: Test device_del after drive_del, Markus Armbruster, 2014/10/02
- [Qemu-devel] [PATCH 3/6] blockdev-test: Clean up bogus drive_add argument, Markus Armbruster, 2014/10/02
- [Qemu-devel] [PATCH 1/6] drive_del-test: Merge of qdev-monitor-test, blockdev-test, Markus Armbruster, 2014/10/02
- Re: [Qemu-devel] [PATCH 0/6] Improve drive_del test coverage, Stefan Hajnoczi, 2014/10/04