[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/3] iotests: Use _img_info
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 1/3] iotests: Use _img_info |
Date: |
Tue, 30 Sep 2014 14:14:50 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.1.1 |
On 09/30/2014 01:31 PM, Max Reitz wrote:
> qemu-img info should only be used directly if the format-specific
> information or the name of the format is relevant (some tests explicitly
> test format-specific information; test 082 uses qcow2-specific settings
> to test the qemu-img interface); otherwise, tests should always use
> _img_info instead.
>
> Test 082 was touched only partially. It does test the qemu-img
> interface; however, its invocations of qemu-img info are not real tests
> but rather verifications, so if format-specific information is not
> important for the test, there is no reason not to use _img_info. In
> contrast to directly invoking qemu-img info, "qcow2" is replaced by
> "IMGFMT"; but as "qcow2" is only mentioned once in test 082 (in
> _supported_fmt), I consider this an improvement.
>
> Signed-off-by: Max Reitz <address@hidden>
> ---
> tests/qemu-iotests/070 | 2 +-
> tests/qemu-iotests/070.out | 5 ++---
> tests/qemu-iotests/082 | 12 +++++-----
> tests/qemu-iotests/082.out | 55
> ++++++++++------------------------------------
> tests/qemu-iotests/095 | 4 ++--
> tests/qemu-iotests/095.out | 16 ++++----------
> 6 files changed, 26 insertions(+), 68 deletions(-)
>
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature