[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 1/5] qdev: add description field in PropertyI
From: |
Michael S. Tsirkin |
Subject: |
Re: [Qemu-devel] [PATCH v4 1/5] qdev: add description field in PropertyInfo struct |
Date: |
Tue, 30 Sep 2014 16:55:08 +0300 |
On Tue, Sep 30, 2014 at 03:36:22PM +0200, Paolo Bonzini wrote:
> Il 30/09/2014 15:33, Michael S. Tsirkin ha scritto:
> > > >
> > > The Propertyinfo.name is used to the qdev property's type, please see
> > > PATCH 4:
> > >
> > > - info->type = g_strdup(prop->info->legacy_name ?:
> > > prop->info->name);
> > > + info->type = g_strdup(prop->info->name);
> >
> > I would say this one is more a string than an int.
>
> At the QOM level it is an int, even though it secondarily accepts a
> string in "DD.F" format.
>
> Paolo
That's the only way to specify a function, isn't it?
Maybe it's not a good idea to expose the QOM type in this case.
--
MST
- [Qemu-devel] [PATCH v4 0/5] add description field in ObjectProperty and PropertyInfo struct, arei.gonglei, 2014/09/29
- [Qemu-devel] [PATCH v4 4/5] qmp: print descriptions of object properties, arei.gonglei, 2014/09/29
- [Qemu-devel] [PATCH v4 3/5] qdev: set the object property's description to the qdev property's., arei.gonglei, 2014/09/29
- [Qemu-devel] [PATCH v4 1/5] qdev: add description field in PropertyInfo struct, arei.gonglei, 2014/09/29
- Re: [Qemu-devel] [PATCH v4 1/5] qdev: add description field in PropertyInfo struct, Michael S. Tsirkin, 2014/09/30
- Re: [Qemu-devel] [PATCH v4 1/5] qdev: add description field in PropertyInfo struct, Gonglei, 2014/09/30
- Re: [Qemu-devel] [PATCH v4 1/5] qdev: add description field in PropertyInfo struct, Michael S. Tsirkin, 2014/09/30
- Re: [Qemu-devel] [PATCH v4 1/5] qdev: add description field in PropertyInfo struct, Paolo Bonzini, 2014/09/30
- Re: [Qemu-devel] [PATCH v4 1/5] qdev: add description field in PropertyInfo struct,
Michael S. Tsirkin <=
- Re: [Qemu-devel] [PATCH v4 1/5] qdev: add description field in PropertyInfo struct, Paolo Bonzini, 2014/09/30
- Re: [Qemu-devel] [PATCH v4 1/5] qdev: add description field in PropertyInfo struct, Michael S. Tsirkin, 2014/09/30
- Re: [Qemu-devel] [PATCH v4 1/5] qdev: add description field in PropertyInfo struct, Paolo Bonzini, 2014/09/30
- Re: [Qemu-devel] [PATCH v4 1/5] qdev: add description field in PropertyInfo struct, Gonglei, 2014/09/30
[Qemu-devel] [PATCH v4 5/5] qdev: drop legacy_name from qdev properties, arei.gonglei, 2014/09/29
[Qemu-devel] [PATCH v4 2/5] qom: add description field in ObjectProperty struct, arei.gonglei, 2014/09/29