qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v3 04/12] virtio/vhost-scsi: fix virtio-scsi/vho


From: Cornelia Huck
Subject: Re: [Qemu-devel] [PATCH v3 04/12] virtio/vhost-scsi: fix virtio-scsi/vhost-scsi child refcount in transports
Date: Tue, 30 Sep 2014 12:54:57 +0200

On Tue, 30 Sep 2014 17:49:36 +0800
<address@hidden> wrote:

> From: Gonglei <address@hidden>
> 
> object_initialize() leaves the object with a refcount of 1.
> object_property_add_child() adds its own reference which is dropped
> again when the property is deleted.
> 
> The upshot of this is that we always have a refcount >= 1.  Upon hot
> unplug the virtio-scsi/vhost-scsi child is not finalized!
> 
> Drop our reference after the child property has been added to the
> parent.
> 
> Signed-off-by: Gonglei <address@hidden>
> ---
>  hw/s390x/s390-virtio-bus.c | 2 ++
>  hw/s390x/virtio-ccw.c      | 2 ++
>  hw/virtio/virtio-pci.c     | 2 ++
>  3 files changed, 6 insertions(+)
> 

This one was also

Reviewed-by: Cornelia Huck <address@hidden>




reply via email to

[Prev in Thread] Current Thread [Next in Thread]