[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 4/7] qom: add description field in ObjectProp
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH v3 4/7] qom: add description field in ObjectProperty struct |
Date: |
Mon, 29 Sep 2014 15:35:26 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.1.1 |
Il 27/09/2014 07:13, address@hidden ha scritto:
> +void object_property_set_description(Object *obj, const char *name,
> + const char *description, Error **errp)
> +{
> + ObjectProperty *op;
> +
> + op = object_property_find(obj, name, errp);
> + if (!op) {
> + return;
> + }
The old description is leaked here if it is not NULL.
Since you are doing v4, please move the object_property_add_alias change
here, too.
Paolo
> + op->description = description ? g_strdup(description) : NULL;
> +}
> +
- [Qemu-devel] [PATCH v3 0/7] add description field in ObjectProperty and PropertyInfo struct, arei.gonglei, 2014/09/27
- [Qemu-devel] [PATCH v3 6/7] qmp: print descriptions of object properties, arei.gonglei, 2014/09/27
- [Qemu-devel] [PATCH v3 2/7] qom: add error handler for object alias property, arei.gonglei, 2014/09/27
- [Qemu-devel] [PATCH v3 7/7] qdev: drop legacy_name from qdev properties, arei.gonglei, 2014/09/27
- [Qemu-devel] [PATCH v3 5/7] qdev: set the object property's description to the qdev property's., arei.gonglei, 2014/09/27
- [Qemu-devel] [PATCH v3 4/7] qom: add description field in ObjectProperty struct, arei.gonglei, 2014/09/27
- Re: [Qemu-devel] [PATCH v3 4/7] qom: add description field in ObjectProperty struct,
Paolo Bonzini <=
- [Qemu-devel] [PATCH v3 3/7] qdev: add description field in PropertyInfo struct, arei.gonglei, 2014/09/27
- [Qemu-devel] [PATCH v3 1/7] qom: add error handler for object_property_print(), arei.gonglei, 2014/09/27
- Re: [Qemu-devel] [PATCH v3 0/7] add description field in ObjectProperty and PropertyInfo struct, Andreas Färber, 2014/09/29