qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v3 4/7] qom: add description field in ObjectProp


From: Paolo Bonzini
Subject: Re: [Qemu-devel] [PATCH v3 4/7] qom: add description field in ObjectProperty struct
Date: Mon, 29 Sep 2014 15:35:26 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.1.1

Il 27/09/2014 07:13, address@hidden ha scritto:
> +void object_property_set_description(Object *obj, const char *name,
> +                                     const char *description, Error **errp)
> +{
> +    ObjectProperty *op;
> +
> +    op = object_property_find(obj, name, errp);
> +    if (!op) {
> +        return;
> +    }

The old description is leaked here if it is not NULL.

Since you are doing v4, please move the object_property_add_alias change
here, too.

Paolo

> +    op->description = description ? g_strdup(description) : NULL;
> +}
> +




reply via email to

[Prev in Thread] Current Thread [Next in Thread]