qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2 1/2] block/raw-posix: Fix disk corruption in


From: Eric Blake
Subject: Re: [Qemu-devel] [PATCH v2 1/2] block/raw-posix: Fix disk corruption in try_fiemap
Date: Fri, 26 Sep 2014 11:09:30 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.1.0

On 09/25/2014 05:14 PM, Tony Breeds wrote:
> Using fiemap without FIEMAP_FLAG_SYNC is a known corrupter.
> 
> Add the FIEMAP_FLAG_SYNC flag to the FS_IOC_FIEMAP ioctl.  This has
> the downside of significantly reducing performance.
> 
> Reported-By: Michael Steffens <address@hidden>
> Signed-off-by: Tony Breeds <address@hidden>
> Cc: Kevin Wolf <address@hidden>
> Cc: Markus Armbruster <address@hidden>
> Cc: Stefan Hajnoczi <address@hidden>
> Cc: Max Reitz <address@hidden>
> Cc: Pádraig Brady <address@hidden>
> Cc: Eric Blake <address@hidden>
> ---
> Changes since v1:
>  - split in to 2 patches
>  - tried to make the commit messages better
> 
>  block/raw-posix.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Eric Blake <address@hidden>

[you buried your patches in deep reply to a longer thread, making them
harder to find; in the future, you can just send a v2 as a new top-level
thread]

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]