[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH qom v3 00/14] GPIO/IRQ QOMification: Phase 2 - G
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH qom v3 00/14] GPIO/IRQ QOMification: Phase 2 - Getting rid of SYSBUS IRQs |
Date: |
Fri, 26 Sep 2014 15:13:32 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.1.1 |
Il 26/09/2014 07:16, Peter Crosthwaite ha scritto:
> Hi All,
>
> So phase one was the QOMification of qemu_irq. This is the next step.
> We start to setup GPIOs as proper QOM objects. Inputs are child objects
> of their device. Outputs are settable Links and connection is made
> via proper setting of a QOM link.
>
> We then cleanup Sysbus to simply re-use device level GPIOs and get rid
> of it's special IRQ handling code.
>
> CHanged since v2:
> Remove num_irq from sysbus (P14)
> Removed out of tree deps.
> Changed since v1:
> Addressed Alex review
> Dropped IRQ g_new0 changes
>
>
>
> Peter Crosthwaite (14):
> qdev: gpio: Don't allow name share between I and O
> qdev: gpio: Register GPIO inputs as child objects
> qdev: gpio: Register GPIO outputs as QOM links
> qmp: qstring: Handle NULL strings
> qom: Allow clearing of a Link property
> qom: Demote already-has-a-parent to a regular error
> qdev: gpio: Re-impement qdev_connect_gpio QOM style
> qdev: gpio: Add API for intercepting a GPIO
> qtest/irq: Rework IRQ interception
> irq: Remove qemu_irq_intercept_out
> qdev: gpio: delete NamedGPIOList::out
> qdev: gpio: Remove qdev_init_gpio_out x1 restriction
> qdev: gpio: Define qdev_pass_gpios()
> sysbus: Use TYPE_DEVICE GPIO functionality
>
> hw/core/irq.c | 8 +----
> hw/core/qdev.c | 90
> ++++++++++++++++++++++++++++++++++++++++++++++----
> hw/core/sysbus.c | 20 ++---------
> include/hw/irq.h | 1 -
> include/hw/qdev-core.h | 6 +++-
> include/hw/sysbus.h | 7 ++--
> qobject/qstring.c | 12 ++++---
> qom/object.c | 10 ++++--
> qtest.c | 15 ++++++---
> 9 files changed, 120 insertions(+), 49 deletions(-)
>
Apart from the couple of patches I replied to,
Reviewed-by: Paolo Bonzini <address@hidden>
Alex, do you want to pick it up and send it together with your sysbus
patches?
Paolo
- [Qemu-devel] [PATCH qom v3 06/14] qom: Demote already-has-a-parent to a regular error, (continued)
- [Qemu-devel] [PATCH qom v3 06/14] qom: Demote already-has-a-parent to a regular error, Peter Crosthwaite, 2014/09/26
- [Qemu-devel] [PATCH qom v3 07/14] qdev: gpio: Re-impement qdev_connect_gpio QOM style, Peter Crosthwaite, 2014/09/26
- [Qemu-devel] [PATCH qom v3 08/14] qdev: gpio: Add API for intercepting a GPIO, Peter Crosthwaite, 2014/09/26
- [Qemu-devel] [PATCH qom v3 09/14] qtest/irq: Rework IRQ interception, Peter Crosthwaite, 2014/09/26
- [Qemu-devel] [PATCH qom v3 10/14] irq: Remove qemu_irq_intercept_out, Peter Crosthwaite, 2014/09/26
- [Qemu-devel] [PATCH qom v3 11/14] qdev: gpio: delete NamedGPIOList::out, Peter Crosthwaite, 2014/09/26
- [Qemu-devel] [PATCH qom v3 13/14] qdev: gpio: Define qdev_pass_gpios(), Peter Crosthwaite, 2014/09/26
- [Qemu-devel] [PATCH qom v3 14/14] sysbus: Use TYPE_DEVICE GPIO functionality, Peter Crosthwaite, 2014/09/26
- [Qemu-devel] [PATCH qom v3 12/14] qdev: gpio: Remove qdev_init_gpio_out x1 restriction, Peter Crosthwaite, 2014/09/26
- Re: [Qemu-devel] [PATCH qom v3 00/14] GPIO/IRQ QOMification: Phase 2 - Getting rid of SYSBUS IRQs,
Paolo Bonzini <=