[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 24/36] s390x: convert s390-virtio to hotplug
From: |
Cornelia Huck |
Subject: |
Re: [Qemu-devel] [PATCH v2 24/36] s390x: convert s390-virtio to hotplug handler API |
Date: |
Fri, 26 Sep 2014 13:36:50 +0200 |
On Fri, 26 Sep 2014 13:31:21 +0200
Igor Mammedov <address@hidden> wrote:
> On Fri, 26 Sep 2014 13:15:16 +0200
> Cornelia Huck <address@hidden> wrote:
>
> > On Fri, 26 Sep 2014 09:28:29 +0000
> > Igor Mammedov <address@hidden> wrote:
> >
> > > Signed-off-by: Igor Mammedov <address@hidden>
> > > ---
> > > v2:
> > > fix not working unplug
> >
> > While the current code for s390-virtio implements unplug, the transport
> > per se does not really support unplug (and never has), only hotplugging
> > of devices. I removed the ->unplug callback and qemu now behaves like
> > I'd expect: I can add devices with device_add, but device_del leaves
> > them in place. That would be the way to go for me.
> Would a path to remove unplug on top of this one do or you'd prefer
> me to respin this patch without unplug?
Whatever works best for you. I don't think it's worth adding an extra
patch except if it saves you a respin of the whole series.
- [Qemu-devel] [PATCH v2 18/36] qdev: drop hotplug check from bus_add_child(), (continued)
- [Qemu-devel] [PATCH v2 18/36] qdev: drop hotplug check from bus_add_child(), Igor Mammedov, 2014/09/26
- [Qemu-devel] [PATCH v2 17/36] qdev: add wrapper to set BUS as HotplugHandler, Igor Mammedov, 2014/09/26
- [Qemu-devel] [PATCH v2 20/36] virtio-pci: drop BusState.allow_hotplug, Igor Mammedov, 2014/09/26
- [Qemu-devel] [PATCH v2 21/36] virtio-serial: convert to hotplug-handler API, Igor Mammedov, 2014/09/26
- [Qemu-devel] [PATCH v2 22/36] virtio-mmio: drop useless bus->allow_hotplug = 0, Igor Mammedov, 2014/09/26
- [Qemu-devel] [PATCH v2 23/36] s390x: drop not used allow_hotplug in event-facility, Igor Mammedov, 2014/09/26
- [Qemu-devel] [PATCH v2 24/36] s390x: convert s390-virtio to hotplug handler API, Igor Mammedov, 2014/09/26
- [Qemu-devel] [PATCH v3 24/36] s390x: convert s390-virtio to hotplug handler API, Igor Mammedov, 2014/09/26
- [Qemu-devel] [PATCH v4 24/36] s390x: convert s390-virtio to hotplug handler API, Igor Mammedov, 2014/09/26
[Qemu-devel] [PATCH v2 25/36] s390x: convert virtio-ccw to hotplug handler API, Igor Mammedov, 2014/09/26
[Qemu-devel] [PATCH v2 26/36] scsi: set SCSI BUS itself as default HotplugHandler, Igor Mammedov, 2014/09/26
[Qemu-devel] [PATCH v2 31/36] usb-bot: drop not needed "allow_hotplug = 0", Igor Mammedov, 2014/09/26
[Qemu-devel] [PATCH v2 33/36] usb: convert usb-ccid to hotplug handler API, Igor Mammedov, 2014/09/26