[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v6 07/10] target-arm: A64: Emulate the HVC insn
From: |
Edgar E. Iglesias |
Subject: |
Re: [Qemu-devel] [PATCH v6 07/10] target-arm: A64: Emulate the HVC insn |
Date: |
Fri, 26 Sep 2014 09:06:08 +1000 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Fri, Sep 26, 2014 at 12:01:11AM +0100, Peter Maydell wrote:
> On 25 September 2014 23:20, Edgar E. Iglesias <address@hidden> wrote:
> > On Thu, Sep 25, 2014 at 07:39:32PM +0100, Peter Maydell wrote:
> >> HCR.TGE isn't actually relevant for some exceptions
> >> (eg SMC), and the HVC handling you have below
> >> effectively ends up ignoring the route_to_el2
> >> information. That suggests to me that you should put
> >> this code in a default: case in the switch below.
> >
> > I don't really test nor support TGE so I'll just drop the TGE part.
>
> I'd rather we just implemented it properly...
IMO, It's not about implementing it properly. It's about implementing the
EL3/2 support incrementally. The spec is too big to add all the features
at once.
Cheers,
Edgar
- Re: [Qemu-devel] [PATCH v6 02/10] target-arm: Add SCR_EL3, (continued)
- [Qemu-devel] [PATCH v6 03/10] target-arm: A64: Refactor aarch64_cpu_do_interrupt, Edgar E. Iglesias, 2014/09/13
- [Qemu-devel] [PATCH v6 04/10] target-arm: Break out exception masking to a separate func, Edgar E. Iglesias, 2014/09/13
- [Qemu-devel] [PATCH v6 05/10] target-arm: Don't take interrupts targeting lower ELs, Edgar E. Iglesias, 2014/09/13
- [Qemu-devel] [PATCH v6 06/10] target-arm: A64: Correct updates to FAR and ESR on exceptions, Edgar E. Iglesias, 2014/09/13
- [Qemu-devel] [PATCH v6 07/10] target-arm: A64: Emulate the HVC insn, Edgar E. Iglesias, 2014/09/13
[Qemu-devel] [PATCH v6 08/10] target-arm: A64: Emulate the SMC insn, Edgar E. Iglesias, 2014/09/13
- Re: [Qemu-devel] [PATCH v6 08/10] target-arm: A64: Emulate the SMC insn, Greg Bellows, 2014/09/17
- Re: [Qemu-devel] [PATCH v6 08/10] target-arm: A64: Emulate the SMC insn, Peter Maydell, 2014/09/25
- Re: [Qemu-devel] [PATCH v6 08/10] target-arm: A64: Emulate the SMC insn, Edgar E. Iglesias, 2014/09/25
- Re: [Qemu-devel] [PATCH v6 08/10] target-arm: A64: Emulate the SMC insn, Peter Maydell, 2014/09/25
- Re: [Qemu-devel] [PATCH v6 08/10] target-arm: A64: Emulate the SMC insn, Edgar E. Iglesias, 2014/09/25
- Re: [Qemu-devel] [PATCH v6 08/10] target-arm: A64: Emulate the SMC insn, Peter Maydell, 2014/09/25
- Re: [Qemu-devel] [PATCH v6 08/10] target-arm: A64: Emulate the SMC insn, Edgar E. Iglesias, 2014/09/25
- Re: [Qemu-devel] [PATCH v6 08/10] target-arm: A64: Emulate the SMC insn, Edgar E. Iglesias, 2014/09/26